Deprecate transaction module #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #442 +/- ##
==========================================
- Coverage 89.58% 89.03% -0.55%
==========================================
Files 28 28
Lines 2227 2280 +53
==========================================
+ Hits 1995 2030 +35
- Misses 232 250 +18 |
|
Perhaps we should add a migration guide to the documentation? |
|
@kevinheavey Actually. I think it'd be better to emit a depreciation warning to notify users to use the solder's transaction rather than outright deletion. |
|
Could you please fix this issue #453, then merge it using pull request and then remove from solana.transaction import Transaction so I can use older version of solana-py even if its removed. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transaaction module is broken (see #268) and
solders.transactionworks so I guess we should just use that?This also entails changing the
send_transactionmethods such that it is the caller's job to fetch a recent blockhash and sign the transaction